-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing Netty4 local copy and consume from Maven #76
Removing Netty4 local copy and consume from Maven #76
Conversation
Signed-off-by: Sarat Vemulapalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the targetExclude("**/netty4/*")
line from gradle/formatting.gradle
(spotless license exclusion).
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the javadoc exclusion which you also caught. LGTM!
@@ -44,6 +44,7 @@ configurations { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the commented code here: https://github.com/opensearch-project/opensearch-sdk/pull/76/files#diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7R55-R63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link redirects to the same diff. Could you point me to the link on main
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why the link redirects to the same diff. May be since it's not a part of this PR but here it is https://github.com/opensearch-project/opensearch-sdk/blob/main/build.gradle#L55-L62
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit. Rest LGTM!
Thanks @saratvemulapalli for this change.
Signed-off-by: Sarat Vemulapalli <[email protected]>
Signed-off-by: Sarat Vemulapalli <[email protected]>
67ff1b9
Signed-off-by: Daniel Widdis <[email protected]>
* Delete unnecessary netty licenses missed in #76 Signed-off-by: Daniel Widdis <[email protected]> * Add copyright line to license header Signed-off-by: Daniel Widdis <[email protected]> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
) * Removing Netty4 local copy and consume from Maven Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing from spotless exclusion Signed-off-by: Sarat Vemulapalli <[email protected]> * Removing from JavaDocs Signed-off-by: Sarat Vemulapalli <[email protected]> * Addressing comments Signed-off-by: Sarat Vemulapalli <[email protected]>
* Delete unnecessary netty licenses missed in opensearch-project#76 Signed-off-by: Daniel Widdis <[email protected]> * Add copyright line to license header Signed-off-by: Daniel Widdis <[email protected]> * Add copyright to headers via spotlessApply Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: Daniel Widdis <[email protected]>
Signed-off-by: Sarat Vemulapalli [email protected]
Description
Removing local copy of Netty4 and consume from OpenSearch as Maven dependency.
Thanks to @dbwiddis's PR on OpenSearch: opensearch-project/OpenSearch#4054
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.