Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize calc() usage in scss files #1002

Open
AMoo-Miki opened this issue Aug 30, 2023 · 1 comment · May be fixed by #1158
Open

Optimize calc() usage in scss files #1002

AMoo-Miki opened this issue Aug 30, 2023 · 1 comment · May be fixed by #1158
Assignees
Labels
enhancement New feature or request

Comments

@AMoo-Miki
Copy link
Collaborator

Moving from node-sass to sass-embedded, all the divisions had to be converted to calc(). There is an opportunity to make the code look nicer by moving some of the math around these calc() calls inside it. However, these changes should be mindful of the units of the variables since mixed %, px, and *em will need to be calculated at runtime.

@AMoo-Miki AMoo-Miki added the enhancement New feature or request label Aug 30, 2023
@ShatilKhan
Copy link
Contributor

@AMoo-Miki @joshuarrrr
If this issue is open, I'd like to take this one

@ShatilKhan ShatilKhan linked a pull request Nov 16, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants