Support configurable timeout #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
rupal-bq
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
|
CI failure not related to this change. |
joshuali925
reviewed
Feb 26, 2024
src/arguments.js
Outdated
| @@ -67,7 +67,10 @@ async function getCommandArguments() { | |||
| .env(ENV_VAR.EMAIL_NOTE)) | |||
| .addOption(new Option('--selfsignedcerts <flag>', 'enable or disable self-signed certicates for smtp transport') | |||
| .default(DEFAULT_SELF_SIGNED_CERTIFICATES) | |||
| .choices(['true', 'false'])); | |||
| .choices(['true', 'false'])) | |||
| .addOption(new Option('--timeout <timeout>', 'timeout for generating report') | |||
There was a problem hiding this comment.
it might be better to include the unit in the option name (--timeout-ms) or in the description
Signed-off-by: Rupal Mahajan <[email protected]>
done
Included timeout unit in description |
joshuali925
reviewed
Feb 26, 2024
USER_GUIDE.md
Outdated
| @@ -41,6 +41,7 @@ Option | Default Value | Valid Options | Environment Variable | Description | |||
| --subject | This is an email containing your dashboard report | - | OPENSEARCH_SUBJECT | subject for the email | |||
| --note | Hi,\nHere is the latest report! | string or path to text file | OPENSEARCH_EMAIL_NOTE | The email body | |||
| --selfsignedcerts | false | true, false | - | enable or disable self-signed certicates for smtp transport | |||
| --timeout | 300000ms | - | OPENSEARCH_TIMEOUT | timeout for generating report in ms | |||
There was a problem hiding this comment.
the value shouldn't contain ms or does it not matter?
There was a problem hiding this comment.
Good catch. the value shouldn't contain ms.
Signed-off-by: Rupal Mahajan <[email protected]>
joshuali925
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#61
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.