Update condition to select tenant #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
…indow Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
rupal-bq
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Feb 28, 2024
| try { | ||
| if (multitenancy === true) { | ||
| if (multitenancy === true && tenantSelection !== null) { |
There was a problem hiding this comment.
if tenant selection is null, is it possible that the Select your tenant popup didn't show up but user is still in a wrong tenant?
for example the dashboard is in global tenant but after login, user is in private tenant and the Select your tenant didn't show up, would that happen?
There was a problem hiding this comment.
That shouldn't happen when report is generated with short URL with tenant info. e.g. https://<domain>.us-west-2.on.aws/_dashboards/goto/8fa30d307ea81f81a5edc692e189c297?security_tenant=global
Signed-off-by: Rupal Mahajan <[email protected]>
YANG-DB
approved these changes
Feb 28, 2024
Signed-off-by: Rupal Mahajan <[email protected]>
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#64
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.