Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Windows support to 1.x branch #2281

Closed
13 tasks done
Tracked by #181
rishabh6788 opened this issue Nov 29, 2022 · 2 comments
Closed
13 tasks done
Tracked by #181

Backport Windows support to 1.x branch #2281

rishabh6788 opened this issue Nov 29, 2022 · 2 comments
Assignees
Labels

Comments

@rishabh6788
Copy link

rishabh6788 commented Nov 29, 2022

Coming from opensearch-project/opensearch-plugins#181, backport Windows support to 1.x branch.

Critical Path

  • Increment to 1.3.7
  • Windows demo script.bat
  • Build on windows machine
  • Run CI on Windows
    • JDK 11
    • JDK 14
    • JDK 8
  • JDK8 compatibility for Utf-8
  • Plugin install for Windows

Non Blockers

  • Test reliability
  • Github workflow updates
  • Branch protection rules
  • Spotbugs

Not in scope

  • Backwards compatibility testing

If you are already have an issue tracking backport Windows CI to 1.x branch, please link here.

@rishabh6788 rishabh6788 added release Project release windows untriaged Require the attention of the repository maintainers and may need to be prioritized labels Nov 29, 2022
@cwperks
Copy link
Member

cwperks commented Dec 1, 2022

While trying to backport these 2 PRs I encountered some issues around Java 8:

  1. SecurityUtilsTest - Pattern.onMatchPredicate is not available, List.of is not available
  2. FIleWriter and FileReader both do not have constructors that take Charset.

The work I have done so far can be found on this branch: #2206 - Fix windows encoding issues
#2190 - Add CI for Windows and MacOS platformshttps://github.com/cwperks/security/tree/backport/backport-2206-to-1.3

@peternied
Copy link
Member

The PR #2291 in draft handles all of the outstanding critical path except for JDK14. I'll hunt that down tomorrow while getting the remaining changes reviewed.

@davidlago @CEHENKLE @rishabh6788 Security is building in 1.3.7 and is part of the distribution. Downstream teams should not be blocked for any build/testing. Based of the current speed of development Security will have delivered all critical path issues by EOD Monday Dec 5 for the security plugin.

@peternied peternied added v1.3.7 and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants