Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right now each reconcile functions call get for DPA, we can do it once and pass it to each function #1128

Closed
kaovilai opened this issue Aug 11, 2023 · 2 comments · Fixed by #1316
Closed

Right now each reconcile functions call get for DPA, we can do it once and pass it to each function #1128

kaovilai opened this issue Aug 11, 2023 · 2 comments · Fixed by #1316
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@kaovilai
Copy link
Member 

	// TODO: Right now each reconcile functions call get for DPA, we can do it once and pass it to each function

https://github.com/kaovilai/oadp-operator/blob/27cccabbd2e845da21ef49489e7506f10c30696d/controllers/dpa_controller.go#L215
@kaovilai kaovilai added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 11, 2023
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2023
@kaovilai
Copy link
Member Author

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 14, 2023
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Feb 6, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
7d9cd21
@stillalearner stillalearner mentioned this issue Feb 6, 2024
Merged
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Feb 7, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
268eb03
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Feb 14, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
95fc7b5
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Feb 14, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
59f86fd
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Apr 24, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
a595dc2
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
bbdefaa
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
1c87757
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
4aa82f7
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
5d824b8
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
8e98399
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 10, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
ff98b21
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 11, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
1082e59
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 11, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
35ffda4
stillalearner added a commit to stillalearner/oadp-operator that referenced this issue Oct 11, 2024
@stillalearner
fix openshift#1128: Removed multiple DPA get calls for Reconcilers
ee2f611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1128: Removed multiple DPA get calls for Reconcilers stillalearner/oadp-operator
2 participants
@openshift-bot @kaovilai