fix: CI check go dependencies #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
This comment was marked as outdated.
This comment was marked as outdated.
kaovilai
previously approved these changes
Mar 22, 2024
This comment was marked as outdated.
This comment was marked as outdated.
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
shubham-pampattiwar
previously approved these changes
Sep 24, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
mateusoliveira43
dismissed stale reviews from shubham-pampattiwar and kaovilai
via
fd50f0c
mateusoliveira43
force-pushed
the
fix/check-go-dependencies
branch
from
9f92c9a
to
fd50f0c
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
shubham-pampattiwar
approved these changes
Sep 30, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/recheck |
|
/retest |
openshift-merge-bot
bot
merged commit bc2e993
into
openshift:master
9 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes were made
Fixes #1369
How the changes were made
Created make command that will check if
go mod tidyandgo mod verifywere run.How to test the changes made
Test new command, running
make check-go-dependenciesormake test