Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix odo describe panic without the context directory #5404

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Fix odo describe panic without the context directory #5404

merged 3 commits into from
Jan 31, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind bug

What does this PR do / why we need it:
This PR fixes the panic caused when running odo describe without the context directory.
Which issue(s) this PR fixes:

Fixes #5245

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

odo create nodejs mynode --app myapp --project myproject
odo push
<cd outside the context directory>
odo describe mynode --app myapp --project myproject

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2022
@netlify
Copy link

netlify bot commented Jan 31, 2022 •
edited
Loading

✔️ Deploy Preview for odo-docusaurus-preview canceled.

🔨 Explore the source changes: a227ca3

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/61f7d1b7752682000853f4f2

@openshift-ci openshift-ci bot requested review from dharmit and feloy January 31, 2022 07:17
@odo-robot
Copy link

odo-robot bot commented Jan 31, 2022 •
edited
Loading

Validate Tests on commit 648b5a7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 31, 2022 •
edited
Loading

OpenShift Tests on commit 648b5a7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 31, 2022 •
edited
Loading

Kubernetes Tests on commit 648b5a7 finished successfully.
View logs: TXT HTML

@dharmit
Copy link
Member

dharmit commented Jan 31, 2022

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharmit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. Required by Prow. approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. labels Jan 31, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 31, 2022
@valaparthvi
Copy link
Contributor Author

@dharmit can you re-lgtm?

@feloy
Copy link
Contributor

feloy commented Jan 31, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 31, 2022
@openshift-merge-robot openshift-merge-robot merged commit bf906ff into redhat-developer:main Jan 31, 2022
@odo-robot
Copy link

odo-robot bot commented Feb 1, 2022

Unit Tests on commit fb61b9e finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/cherrypick v2

@openshift-cherrypick-robot
Copy link

@valaparthvi: only redhat-developer org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherrypick v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor Author

/cherrypick v2

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 7, 2022
Merged
@openshift-cherrypick-robot
Copy link

@valaparthvi: new pull request created: #5438

In response to this:

/cherrypick v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@valaparthvi @dharmit @cdrage
Fix odo describe panic without the context directory (redhat-develope…
f19e226 
…r#5404)

* Fix odo describe without the context directory

* Update pkg/component/component_full_description.go

Co-authored-by: Dharmit Shah <[email protected]>

* Fix unit tests

Co-authored-by: Dharmit Shah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmit dharmit dharmit left review comments

@feloy feloy Awaiting requested review from feloy

Assignees

@dharmit dharmit

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo component describe without context fails
5 participants
@valaparthvi @dharmit @feloy @openshift-cherrypick-robot @openshift-merge-robot