Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set replicas using devfile library #5413

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Set replicas using devfile library #5413

merged 1 commit into from
Feb 14, 2022

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Feb 2, 2022

What type of PR is this:
/kind cleanup

What does this PR do / why we need it:
Sets replicas using devfile library. We need it as we have pushed the necessary change in devfile library, and now odo just needs to use it.

Which issue(s) this PR fixes:

Fixes #5347

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
Tests should pass.

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for odo-docusaurus-preview canceled.

🔨 Explore the source changes: a55027f

🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/620a3159aecf47000852796f

@openshift-ci openshift-ci bot requested review from cdrage and feloy February 2, 2022 05:06
@odo-robot
Copy link

odo-robot bot commented Feb 2, 2022

OpenShift Tests on commit 0b60dc8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2022

Unit Tests on commit 0b60dc8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2022

Validate Tests on commit 0b60dc8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 2, 2022

Kubernetes Tests on commit 0b60dc8 finished with errors.
View logs: TXT HTML

@dharmit
Copy link
Member Author

dharmit commented Feb 2, 2022

4.9 integration tests are full of below error:

[odo]  ✗  1 error occurred:
[odo] 	* devfile contains multiple endpoint entries with same TargetPort: 3000 

I think #5407 is addressing this. @valaparthvi WDYT? I see your PR failing with bunch of:

[odo]  ✗  URL creation failed:
[odo] 	- port 8080 already exists in devfile endpoint entry under container "py-web" 

@valaparthvi
Copy link
Contributor

You are facing these problems because devfile libraries recently added duplicate port validation checks. 5407 is accommodating this validation for odo. I need to fix the tests tho.

@dharmit
Copy link
Member Author

dharmit commented Feb 2, 2022

You are facing these problems because devfile libraries recently added duplicate port validation checks. 5407 is accommodating this validation for odo. I need to fix the tests tho.

Yeah, I know the devfile PR that caused this and the reason why they made that change. The reason I pinged you was to understand if your PR is going to address the tests. That is why I said in my original message that -

I think #5407 is addressing this. @valaparthvi WDYT?

@valaparthvi
Copy link
Contributor

Yes. My PR will address these failures.

@feloy
Copy link
Contributor

feloy commented Feb 10, 2022

Now that #5407 is merged, tests should pass if you rebase your PR

@dharmit
Copy link
Member Author

dharmit commented Feb 10, 2022

Now that #5407 is merged, tests should pass if you rebase your PR

Thanks, I had missed the need of rebase. Done that now.

@odo-robot
Copy link

odo-robot bot commented Feb 10, 2022

Windows Tests (OCP) on commit 0b60dc8 finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Feb 14, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 14, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Feb 14, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 14, 2022
@dharmit
Copy link
Member Author

dharmit commented Feb 14, 2022

Force-push was to fix conflicts.

@sonarcloud
Copy link

sonarcloud bot commented Feb 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@feloy
Copy link
Contributor

feloy commented Feb 14, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 14, 2022
@openshift-merge-robot openshift-merge-robot merged commit 32d8a04 into redhat-developer:main Feb 14, 2022
@dharmit dharmit deleted the fix-5347 branch February 16, 2022 06:00
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@rm3l rm3l added the area/refactoring Issues or PRs related to code refactoring label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devfile/library add replicas to generator.DeploymentParams structure
5 participants