-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set replicas using devfile library #5413
Conversation
✔️ Deploy Preview for odo-docusaurus-preview canceled. 🔨 Explore the source changes: a55027f 🔍 Inspect the deploy log: https://app.netlify.com/sites/odo-docusaurus-preview/deploys/620a3159aecf47000852796f |
4.9 integration tests are full of below error:
I think #5407 is addressing this. @valaparthvi WDYT? I see your PR failing with bunch of:
|
You are facing these problems because devfile libraries recently added duplicate port validation checks. 5407 is accommodating this validation for odo. I need to fix the tests tho. |
Yeah, I know the devfile PR that caused this and the reason why they made that change. The reason I pinged you was to understand if your PR is going to address the tests. That is why I said in my original message that -
|
Yes. My PR will address these failures. |
Now that #5407 is merged, tests should pass if you rebase your PR |
Thanks, I had missed the need of rebase. Done that now. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Force-push was to fix conflicts. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
What type of PR is this:
/kind cleanup
What does this PR do / why we need it:
Sets replicas using devfile library. We need it as we have pushed the necessary change in devfile library, and now odo just needs to use it.
Which issue(s) this PR fixes:
Fixes #5347
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Tests should pass.