Bash completion displays hidden and deprecated flags

[nak3]

Upstream fixed it 2 years ago - spf13/cobra#313, but origin still has the issue (because origin is using older version)

origin/glide.lock

Lines 1064 to 1065 in 35ba454

	- name: github.com/spf13/cobra
	version: f62e98d28ab7ad31d707ba837a966378465c7b57

Steps to reproduce (Following flags are the examples)

$ oc new-build --build-[TAB]
--build-arg=       --build-env=       --build-env-file=  --build-secret=
                        ^                  ^
			+--marked hidden	   +--marked hidden

$  oc new-app --image[TAB]
--image=         --image-stream=
   ^
   +--- deprecated

[php-coder]

@openshift/sig-developer-experience

[soltysh]

I've just double checked the completions file in https://github.com/openshift/origin/tree/master/contrib/completions/ and they are just fine. The aforementioned cobra fix is already included and none of the flags you've mentioned are there.

I'd suggest you verify if the correct completions are properly installed on your system.

[nak3]

Yes, the cobra was updated by #19137 last month. Thank you.

I'd suggest you verify if the correct completions are properly installed on your system.

I installed and used correct completions. But the #19137 was merged between my report and your verify.. 😢