Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook pods are not terminated by the deployment controller when a deployment is cancelled or aborted #8500

Closed
smarterclayton opened this issue Apr 13, 2016 · 3 comments

Comments

@smarterclayton
Copy link
Contributor

I would expect that we would preserve the invariant that all hook pods have terminated (are in failed/succeeded/deleted) before we launch a new deployer pod, but that appears that is not the case today. What would we have to change to guarantee that?

@ironcladlou @Kargakis

@pweil-
Copy link
Contributor

pweil- commented Apr 14, 2016

This isn't a regression. Can we make this a p2 for 3.2?

@0xmichalis
Copy link
Contributor

The deployment controller can try to identify any preexisting deployers for the config of the deployment (before creating the new deployer) and delete if it finds any.

@smarterclayton
Copy link
Contributor Author

smarterclayton commented Apr 14, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants