Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Values Reversed in Client Controls Page #189

Closed
areynold opened this issue Mar 5, 2014 · 1 comment
Closed

Values Reversed in Client Controls Page #189

areynold opened this issue Mar 5, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@areynold
Copy link
Collaborator

areynold commented Mar 5, 2014

When setting Time Until Page is Shown Again, values are translated to minutes before writing to ClientIdleTimeout and ClientForceTimeout in /etc/nodogsplash/nodogsplash.conf. For example, 1 minute would result in ClientIdleTimeout 1 while 1 hour should result in ClientIdleTimeout 60.

The results for hours and days have been swapped, so setting resplash to 1 hour results in ClientIdleTimeout 1440, while setting to 1 day results in ClientIdleSplash 60.

Also, timeout in seconds rounds down to the nearest whole number, making that range effectively useless. Probably best just to drop it.

@jheretic @elationfoundation

@areynold areynold added this to the 1.1 milestone Mar 5, 2014
@areynold areynold added bug and removed 1 - Ready labels Mar 5, 2014
@areynold areynold self-assigned this Mar 6, 2014
@jheretic
Copy link
Member

Superseded by opentechinstitute/luci-commotion-splash#26 and related pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants