Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup spec] Update close watcher logic and focusing steps algo for popup light dismissal #393

Closed
melanierichards opened this issue Aug 27, 2021 · 2 comments
Labels
needs edits This is ready for edits to be made popover The Popover API popover-spec Spec-related issues for the Popover API stale

Comments

@melanierichards
Copy link
Collaborator

melanierichards commented Aug 27, 2021

#355 lands a first editor's draft of <popup> in Open UI, and is intended to be brought to various parts of the HTML spec in WHATWG.

Of the light dismissal section, @domenic's advice and additional advice was to:

  • Add something like the dialog patch to close watcher logic
  • Update the focusing steps algorithm
  • Not to add componentized "light dismissal" definitions anywhere before relevant, i.e. before there are multiple elements that would call into that behavior. That's a little different than what we had planned for Open UI, as we do think there are multiple Open UI components that we imagine will consume from a common definition (whether or not they will all be platform changes remains to be seen).

Opening this issue to track the edit as suggested. We can add a snippet to the Open UI spec as I've done here: https://open-ui.org/components/popup#html-incubation-text-user-interaction-focus-processing-model

@melanierichards melanierichards added needs edits This is ready for edits to be made popover The Popover API labels Aug 27, 2021
@melanierichards melanierichards changed the title [Popup] Update close watcher logic and focusing steps algo for popup closing logic [Popup] Update close watcher logic and focusing steps algo for popup light dismissal Aug 27, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 4, 2022
@mfreed7 mfreed7 changed the title [Popup] Update close watcher logic and focusing steps algo for popup light dismissal [Popup spec] Update close watcher logic and focusing steps algo for popup light dismissal May 13, 2022
@mfreed7 mfreed7 added the popover-spec Spec-related issues for the Popover API label May 13, 2022
@josepharhar
Copy link
Collaborator

Add something like the dialog patch to close watcher logic

We will make sure that close watcher gets integrated when close watcher is added to the HTML spec. I don't feel inclined to also spell out exactly how I'm going to integrate it into HTML in domenic's repo.

Update the focusing steps algorithm

Light dismiss doesn't do this king of patching for focus anymore in my HTML spec PR for popover

Not to add componentized "light dismissal" definitions anywhere before relevant, i.e. before there are multiple elements that would call into that behavior. That's a little different than what we had planned for Open UI, as we do think there are multiple Open UI components that we imagine will consume from a common definition (whether or not they will all be platform changes remains to be seen).

In my HTML spec PR, light dismissal is not an abstraction that only has one consumer - it is specifically defined only for popovers and lives in the popover section.

This issue can be closed.

@mfreed7 mfreed7 closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs edits This is ready for edits to be made popover The Popover API popover-spec Spec-related issues for the Popover API stale
Projects
None yet
Development

No branches or pull requests

3 participants