Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Popup spec] Make get the focusable area steps edits describe the correct behavior #394

Closed
melanierichards opened this issue Aug 27, 2021 · 2 comments
Labels
needs edits This is ready for edits to be made popover The Popover API popover-spec Spec-related issues for the Popover API stale

Comments

@melanierichards
Copy link
Collaborator

#355 lands a first editor's draft of <popup> in Open UI, and is intended to be brought to various parts of the HTML spec in WHATWG.

Of the edits to the "get the focusable area steps", @domenic mentioned:

Interesting. This allows autofocus to focus elements which are not normally focusable (as long as they are not inert). Is that intended behavior?

The normal autofocus behavior does not do this. It performs "getting the focusable area" on the element where autofocus is specified, which might return the element itself, or might return null. If it returns null, then the attribute does nothing.

We should review the edits in that section and make sure all implications are intentional, or correct them.

@melanierichards melanierichards added needs edits This is ready for edits to be made popover The Popover API labels Aug 27, 2021
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 4, 2022
@mfreed7 mfreed7 changed the title [Popup] Make get the focusable area steps edits describe the correct behavior [Popup spec] Make get the focusable area steps edits describe the correct behavior May 13, 2022
@mfreed7 mfreed7 added the popover-spec Spec-related issues for the Popover API label May 13, 2022
@josepharhar
Copy link
Collaborator

My current popover HTML PR uses GetFocusDelegate rather than defining its own focusing steps, so it should not focus elements which are not normally focusable. This issue can be closed

@mfreed7 mfreed7 closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs edits This is ready for edits to be made popover The Popover API popover-spec Spec-related issues for the Popover API stale
Projects
None yet
Development

No branches or pull requests

3 participants