Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align openvino.compile_model and openvino.Core.compile_model functions #19616

Closed
p-wysocki opened this issue Sep 5, 2023 · 3 comments · Fixed by #19778
Closed

Align openvino.compile_model and openvino.Core.compile_model functions #19616

p-wysocki opened this issue Sep 5, 2023 · 3 comments · Fixed by #19778
Assignees
Labels
good first issue Good for newcomers no_stale Do not mark as stale
Milestone

Comments

@p-wysocki
Copy link
Contributor

Context

There are two namespaces from which you can call a compile_model function:

Currently, you can only give model_path argument to openvino.compile_model, which makes its behavior different from openvino.Core.compile_model, which can take three arguments. The goal of this task is to align the functions.

What needs to be done?

  1. Align the function behavior
    This can be done by changing the code for openvino.compile_model from
def compile_model(model_path: Union[str, Path]) -> CompiledModel:

to something along the lines of

def compile_model(
    self,
    model: Union[Model, str, Path],
    device_name: Optional[str] =AUTO”,
    config: Optional[dict] = None,
) -> CompiledModel:
  1. Add tests for openvino.compiled_model covering the new functionality
  2. Create a Pull Request

Resources

Contact points

@p-wysocki
@jiwaszki
@akuporos

Don't hesitate to reach out, we're here to help!

Ticket: 118851

@p-wysocki
Copy link
Contributor Author

PR: #19778

@siddhant-0707
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers no_stale Do not mark as stale
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants