Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove indy-sdk from core #1125

Closed
6 tasks
karimStekelenburg opened this issue Nov 28, 2022 · 1 comment
Closed
6 tasks

Remove indy-sdk from core #1125

karimStekelenburg opened this issue Nov 28, 2022 · 1 comment
Assignees

Comments

@karimStekelenburg
Copy link
Contributor

karimStekelenburg commented Nov 28, 2022

Description

One of the things we're trying to achieve is to remove the dependency on the indy-sdk Rust library. Instead, the indy-sdk related logic will be handled by a set of new components that rely on the newer indy-vdr, aries-askar, and anoncreds-rs Rust libraries. These components should have been finalized in the preceding tasks.

There is a difference, however. Currently, the core of AFJ depends on indy-sdk, which is provided through the indy property inside the AgentDependencies object. In order to make the framework more flexible, this will not be replaced indy-vdr, aries-askar, and anoncreds-rs dependencies. Instead, we will have new packages (or modules) that depend on these libraries, and users can provide these modules to the agent upon initialization.

Assuming the other components are in place, as a final step we need to remove the indy-sdk from the AgentDependencies. This will likely cause some issues that need to be addressed.

Todos

Example

import { Agent } from '@aries-framework/core'
import { agentDependencies } from '@aries-framework/node'
import { IndySdkModule } from '@aries-framework/indy-sdk' 

const agent = new Agent({
  dependencies: agentDependencies,
  config: {},
  modules: {
    indy: new IndySdkModule(), // doesn't expose public api
  }
})
@TimoGlastra
Copy link
Contributor

One addition to this is that we import types from the 'indy-sdk' in quite some places. All types that we need from the indy-sdk should probably just be copied to AFJ and the related packages (I think the AnonCreds related types are already mostly copied in the anoncreds interfaces)

@TimoGlastra TimoGlastra moved this from Todo to Backlog in Ledger Agnostic AnonCreds Dec 16, 2022
@TimoGlastra TimoGlastra changed the title Remove indy-sdk from the agent dependencies Remove indy-sdk from core Jan 10, 2023
@TimoGlastra TimoGlastra self-assigned this Jan 10, 2023
@TimoGlastra TimoGlastra moved this from Backlog to In Review in Ledger Agnostic AnonCreds Feb 17, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Ledger Agnostic AnonCreds Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants