Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification for File? and read_tsv(emptyFile) #196

Closed
antonkulaga opened this issue Mar 7, 2018 · 2 comments
Closed

clarification for File? and read_tsv(emptyFile) #196

antonkulaga opened this issue Mar 7, 2018 · 2 comments
Assignees
Milestone

Comments

@antonkulaga
Copy link

I think that it should be clarified in the specification that:

  1. File? myfile = "does_not_exist" should return null instead of crashing workflow
  2. read_tsv(emptyFile) should return Array[Array[String]] as it is what most libs and tools generate when they are provided an empty array/dictionary for tsv generation.

If this is not clarified in some implementations those functions may work fine, while in others lead to workflow_errors.

@cjllanwarne
Copy link
Contributor

I assume your item (1) is referring to outputs from a task (rather than in the middle of a workflow)?

@jdidion
Copy link
Collaborator

jdidion commented Feb 7, 2024

The section on Files and Optional Outputs addresses #1.

I agree that all of the read_* should have the clarification added that reading from an existing but empty file returns an empty value rather than None.

@jdidion jdidion added this to the 1.1.2 milestone Feb 7, 2024
@jdidion jdidion self-assigned this Feb 10, 2024
@jdidion jdidion closed this as completed May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants