Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move/add instrumentation tests to automation/Extension/webext-instrumentation #330

Closed
motin opened this issue Jun 25, 2019 · 2 comments
Closed
Assignees
Labels
backlog Not a priorty, but nice to have extension Relates to the WebExtension written in TS and JS

Comments

@motin
Copy link
Contributor

motin commented Jun 25, 2019

These tests should be decoupled from the framework tests.

@motin motin self-assigned this Jun 25, 2019
@motin motin added the extension Relates to the WebExtension written in TS and JS label Jun 27, 2019
@motin
Copy link
Contributor Author

motin commented Jul 1, 2019

To ensure that the tests are decoupled from the framework code, it not only needs its own tests, but also its own way of executing those tests.

Unit tests are already set up, but any test that relies on web extension APIs requires testing using a real browser.

I dug around to find the most up to date best practices for testing web extensions using a real browser, and it seems that proper tooling that supports Web Extension developer workflows is still rare, and such tooling that supports Web Extension that uses Web Extension Experiments outside the Firefox source code tree is even rarer.

Findings summarized in motin/firefox-webext-test-automation-example#1

TLDR: Taken all of this into account, my intention is to make https://github.com/mozilla/shield-studies-addon-utils/tree/master/testUtils available outside of the study utils package and then set up Selenium-based tests for webext-instrumentation. I'll possibly evaluate puppeteer-firefox and try out theintern.io as well in order to see if the current best practices can be improved upon.

@englehardt englehardt added the backlog Not a priorty, but nice to have label Nov 6, 2020
@vringar
Copy link
Contributor

vringar commented Dec 21, 2021

I don't think we'll ever separate the instrumentation from OpenWPM ever again.

@vringar vringar closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Not a priorty, but nice to have extension Relates to the WebExtension written in TS and JS
Development

No branches or pull requests

3 participants