-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename and move some properties to where they belong #605
Labels
developer-experience
Workflow improvements
Comments
Hello @vringar can I work on this? |
Sure :) |
Hey @shreyagupta30 are you still on this? |
Hi @vringar, you can take this up. Sorry! |
Moving visit_id into the command_sequence is more work than expected, since we never pass the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
browser_pid
->geckodriver_pid
as this is no longer the Firefox pidMove
visit_id
to be a property of thecommand_sequence
instead of thebrowser
Edit: Scoped this more narrowly as #701 is for the discussion of crawl, browser and task
The text was updated successfully, but these errors were encountered: