Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename and move some properties to where they belong #605

Closed
vringar opened this issue Apr 9, 2020 · 6 comments
Closed

Rename and move some properties to where they belong #605

vringar opened this issue Apr 9, 2020 · 6 comments
Assignees
Labels
developer-experience Workflow improvements

Comments

@vringar
Copy link
Contributor

vringar commented Apr 9, 2020

browser_pid -> geckodriver_pid as this is no longer the Firefox pid
Move visit_id to be a property of the command_sequence instead of the browser
Edit: Scoped this more narrowly as #701 is for the discussion of crawl, browser and task

@shreyagupta30
Copy link

Hello @vringar can I work on this?

@vringar
Copy link
Contributor Author

vringar commented Apr 9, 2020

Sure :)

@vringar
Copy link
Contributor Author

vringar commented May 7, 2020

Hey @shreyagupta30 are you still on this?
Otherwise I'd pick this up myself.

@shreyagupta30
Copy link

Hi @vringar, you can take this up. Sorry!

@birdsarah
Copy link
Contributor

birdsarah commented Jun 29, 2020

@vringar can we scope down this issue to just:

  • browser_pid -> geckodriver_pid as this is no longer the Firefox pid
  • Move visit_id to be a property of the command_sequence instead of the browser

And have #701 for the task / crawl / browser?

@vringar vringar added the developer-experience Workflow improvements label Aug 7, 2020
@vringar
Copy link
Contributor Author

vringar commented Aug 7, 2020

Moving visit_id into the command_sequence is more work than expected, since we never pass the CommandSequence to the BrowserManager only singular commands over the command_queue

@vringar vringar closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Workflow improvements
Projects
None yet
Development

No branches or pull requests

3 participants