Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command table should contain short command names #684

Closed
vringar opened this issue Jun 12, 2020 · 1 comment · Fixed by #753
Closed

Command table should contain short command names #684

vringar opened this issue Jun 12, 2020 · 1 comment · Fixed by #753
Labels
good-first-bug Bugs that are good for a first-time committer to tackle

Comments

@vringar
Copy link
Contributor

vringar commented Jun 12, 2020

It shouldn't be the full type name in the table but so instead of automation.commands...GetCommand
@vringar vringar added good-first-bug Bugs that are good for a first-time committer to tackle help wanted labels Aug 7, 2020
This was referenced Sep 11, 2020
Closed
Closed
@vringar vringar mentioned this issue Sep 30, 2020
Merged
@vringar
Copy link
Contributor Author

vringar commented Oct 5, 2020

We don't need a dedicated method for this as type(command).__name__ gives us exactly what we want.

@vringar vringar closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-bug Bugs that are good for a first-time committer to tackle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Data Aggregator Rewrite openwpm/OpenWPM
1 participant
@vringar