Introducing seed profile #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 40.50% 43.10% +2.59%
==========================================
Files 29 29
Lines 3180 3464 +284
==========================================
+ Hits 1288 1493 +205
- Misses 1892 1971 +79
Continue to review full report at Codecov.
|
vringar
commented
Aug 24, 2020
instead of letting the WebDriverException bubble up we're now turning it into an AssertionError
englehardt
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
@vringar This looks great. I'm glad to see this was relatively straightforward.
Would you mind to review the new documentation I've added in the most recent commit. If it's correct, please merge!
|
Thanks for improving the docs on this! |
Zaxeli
pushed a commit
to Zaxeli/OpenWPM
that referenced
this pull request
Aug 10, 2021
We now differentiate between a seed_profile and a recovery_profile. This allows us to run stateless crawls with seeded profiles without having to restore support for stateful crawls. Co-authored-by: Steven Englehardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #734