Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making memory_watchdog not run by default #785

Merged
merged 9 commits into from
Nov 10, 2020

Conversation

ankushduacodes
Copy link
Contributor

Running test to fix #778

@ankushduacodes ankushduacodes changed the title adding new manager_param -> memery_watchdog Making memory_watchdog not run by default Nov 10, 2020
@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #785 (51da058) into master (2f2f5f5) will decrease coverage by 0.00%.
The diff coverage is 11.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   40.06%   40.06%   -0.01%     
==========================================
  Files          29       29              
  Lines        3157     3120      -37     
==========================================
- Hits         1265     1250      -15     
+ Misses       1892     1870      -22     
Impacted Files Coverage Δ
automation/Commands/command_executor.py 19.23% <ø> (ø)
automation/Commands/profile_commands.py 15.62% <ø> (+0.81%) ⬆️
automation/DataAggregator/parquet_schema.py 100.00% <ø> (ø)
automation/DeployBrowsers/deploy_firefox.py 19.10% <0.00%> (+3.64%) ⬆️
automation/TaskManager.py 73.35% <11.11%> (-4.25%) ⬇️
automation/BrowserManager.py 48.82% <50.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2f5f5...51da058. Read the comment docs.

@vringar
Copy link
Contributor

vringar commented Nov 10, 2020

Thanks for this PR.
Could you please also change demo.py to set memory_watchdog to true?

@vringar vringar self-requested a review November 10, 2020 12:38
@vringar
Copy link
Contributor

vringar commented Nov 10, 2020

Thank you for adding the docs. Could you also make process_watchdog also a manager_param?

@ankushduacodes
Copy link
Contributor Author

Thank you for adding the docs. Could you also make process_watchdog also a manager_param?

Do you want me to make it manager_param in this branch or do you want me to start a new pull request? or may be could do it while resolving #749

@vringar
Copy link
Contributor

vringar commented Nov 10, 2020

Do you want me to make it manager_param in this branch or do you want me to start a new pull request? or may be could do it while resolving #749

You're right it doesn't belong in this PR. Let's do this as part of #749

@vringar
Copy link
Contributor

vringar commented Nov 10, 2020

Do you have anything you want to add to this PR? Otherwise I'm merging this

@ankushduacodes
Copy link
Contributor Author

Do you have anything you want to add to this PR? Otherwise I'm merging this

Everything is Okay from my side, Please go ahead and merge it 🚀

@vringar vringar merged commit 65337e0 into openwpm:master Nov 10, 2020
Zaxeli pushed a commit to Zaxeli/OpenWPM that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenWPM Watchdog Error
2 participants