Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set javascript.options.asyncstack to true #678

Open
englehardt opened this issue Jun 3, 2020 · 6 comments · May be fixed by #910
Open

Set javascript.options.asyncstack to true #678

englehardt opened this issue Jun 3, 2020 · 6 comments · May be fixed by #910
Assignees
@Ayushsunny
Labels
feature-request good-first-bug Bugs that are good for a first-time committer to tackle

Comments

@englehardt
Copy link
Collaborator

See https://searchfox.org/mozilla-central/rev/7cadba1d8b8feaec4615f5bb98aac4b8a719793c/modules/libpref/init/all.js#1132-1141. This is only true by default in Nightly/dev edition.

We should also add test pages for various async API accesses, e.g., setTimeout.
@englehardt englehardt added feature-request good-first-bug Bugs that are good for a first-time committer to tackle labels Jun 3, 2020
@hadiamjad hadiamjad mentioned this issue Jan 21, 2021
Open
@Ayushsunny
Copy link
Contributor

is this still open sir @englehardt ?

@vringar
Copy link
Contributor

vringar commented Apr 26, 2021

As far as I can tell, yes, this issue is still open.
Do you want to work on this after #870

@Ayushsunny
Copy link
Contributor

As far as I can tell, yes, this issue is still open.
Do you want to work on this after #870

yeah sure

@vringar vringar mentioned this issue Apr 29, 2021
Closed
@Ayushsunny
Copy link
Contributor

Hello @vringar Sir I couldn't find the javascript.option.asyncstack which we're going to set true.
can you help me with that ?

@vringar
Copy link
Contributor

vringar commented Apr 29, 2021

Hey,
You will need to set the option true in this function
https://github.com/mozilla/OpenWPM/blob/18e12864cef5d7a8c855db7e78cdeebb7c445836/openwpm/deploy_browsers/configure_firefox.py#L132-L252

I'd expect something like

# Enabling callstack capture across async APIs e.g. setTimeout
prefs["javascript.option.asyncstack"]=True

@Ayushsunny Ayushsunny linked a pull request Apr 30, 2021 that will close this issue
Open
@Ayushsunny
Copy link
Contributor

Hello @vringar Sir I've made PR for this issue.
could you review it pls here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ayushsunny Ayushsunny

Labels
feature-request good-first-bug Bugs that are good for a first-time committer to tackle
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added javascript option asyncstack
3 participants
@englehardt @vringar @Ayushsunny