Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several packages still using .xz compressed source code tarballs #24908

Closed
1 task done
ikazuhiro opened this issue Aug 31, 2024 · 10 comments
Closed
1 task done

Several packages still using .xz compressed source code tarballs #24908

ikazuhiro opened this issue Aug 31, 2024 · 10 comments

Comments

@ikazuhiro
Copy link
Contributor

Describe the bug

Sine openwrt/openwrt@bab3ae2, OpenWrt prefers .gz tarball than .xz for tools. But packages in package directory and package repository still seem to prefer .xz. As a result, dl directory contains many tarballs which have the same content. For example, I can see following redundant tarballs in my dl directory.

autoconf-2.71.tar.gz
autoconf-2.71.tar.xz
automake-1.16.5.tar.gz
automake-1.16.5.tar.xz
e2fsprogs-1.47.0.tar.gz
e2fsprogs-1.47.0.tar.xz
expat-2.6.2.tar.gz
expat-2.6.2.tar.xz
libtool-2.4.7.tar.gz
libtool-2.4.7.tar.xz
patch-2.7.6.tar.gz
patch-2.7.6.tar.xz
zlib-1.3.1.tar.gz
zlib-1.3.1.tar.xz

OpenWrt version

master

OpenWrt release

master

OpenWrt target/subtarget

all

Device

host

Image kind

Self-built image

Steps to reproduce

No response

Actual behaviour

No response

Expected behaviour

No response

Additional info

No response

Diffconfig

No response

Terms

  • I am reporting an issue for OpenWrt, not an unsupported fork.
@ikazuhiro ikazuhiro added the bug label Aug 31, 2024
Copy link

Invalid Version reported. ``
Is this from a clean repository?

Copy link

Invalid Release reported. ``
Is this from a clean repository?

Copy link

Invalid Target/Subtarget reported. ``
Is this from a supported device?

@ynezz
Copy link
Member

ynezz commented Sep 1, 2024

This is not a bug, avoiding xz is intentional after the recent xz utils drama, see bab3ae2 and 706f0e3 as examples.

@ynezz ynezz closed this as completed Sep 1, 2024
@ikazuhiro
Copy link
Contributor Author

Thank you for your replay.
Yes, I know xz related issues, and my question is whether packages remain prefering .xz tarballs. I think there is no advantage to download .xz tarballs which we have already downloaded as other format.

@ynezz
Copy link
Member

ynezz commented Sep 1, 2024

As you can see in the linked openwrt/openwrt@bab3ae2 the .gz or .bz2 archives are now preferred, thus if something still downloads autoconf-2.71.tar.xz then its a bug and if you want that fixed, you need to provide more details, like for example reproducer or complete log.

@ikazuhiro
Copy link
Contributor Author

As I wrote, many packages in package directory and packages repository seems to use .xz tarballs.

$ find package/ -type f -exec grep -B 5 -E '^PKG_SOURCE:=.*\.xz$' {} + | grep -E 'PKG_(NAME|SOURCE):='

(snip)
package/utils/e2fsprogs/Makefile-PKG_NAME:=e2fsprogs
package/utils/e2fsprogs/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
package/utils/util-linux/Makefile-PKG_NAME:=util-linux
package/utils/util-linux/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
package/libs/libtool/Makefile-PKG_NAME:=libtool
package/libs/libtool/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
package/libs/mpfr/Makefile-PKG_NAME:=mpfr
package/libs/mpfr/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
package/libs/zlib/Makefile-PKG_NAME:=zlib
package/libs/zlib/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
package/libs/gmp/Makefile-PKG_NAME:=gmp
package/libs/gmp/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION)$(PKG_REVISION).tar.xz

In packages repository,

$ find . -type f -exec grep -B 5 -E '^PKG_SOURCE:=.*\.xz$' {} + | grep -E 'PKG_(NAME|SOURCE):='

(snip)
./libs/expat/Makefile-PKG_NAME:=expat
./libs/expat/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/m4/Makefile-PKG_NAME:=m4
./devel/m4/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/pkgconf/Makefile-PKG_NAME:=pkgconf
./devel/pkgconf/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/automake/Makefile-PKG_NAME:=automake
./devel/automake/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/patch/Makefile-PKG_NAME:=patch
./devel/patch/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/bison/Makefile-PKG_NAME:=bison
./devel/bison/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/libtool-bin/Makefile-PKG_NAME:=libtool
./devel/libtool-bin/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./devel/autoconf/Makefile-PKG_NAME:=autoconf
./devel/autoconf/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./utils/sed/Makefile-PKG_NAME:=sed
./utils/sed/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./utils/tar/Makefile-PKG_NAME:=tar
./utils/tar/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz
./utils/coreutils/Makefile-PKG_NAME:=coreutils
./utils/coreutils/Makefile:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.xz

You can see .xz tarballs are downloaded when you build above pacakges. If I changed PKG_SOURCE and PKG_HASH values to the same with tools/.../Makefile, tarballs for tools were shared.

@ynezz ynezz transferred this issue from openwrt/openwrt Sep 1, 2024
@ynezz ynezz changed the title package: redundant downloading package tarballs Several packages still using .xz compressed source code tarballs Sep 1, 2024
@ynezz ynezz reopened this Sep 1, 2024
@BKPepe
Copy link
Member

BKPepe commented Sep 1, 2024

As you can see in the linked openwrt/openwrt@bab3ae2 the .gz or .bz2 archives are now preferred, thus if something still downloads autoconf-2.71.tar.xz then its a bug and if you want that fixed, you need to provide more details, like for example reproducer or complete log.

Is this your opinion, or is this the official statement from OpenWrt core members? I've asked on the mailing list 1 about this, but no one responded to it except @robimarko. For me, it makes sense to get away from .tar.xz, but other package maintainers are not united about this and as you can see, recently in PR #24299, it was changed from .tar.gz to .tar.xz for several packages without proper reason, though except that .tar.xz is preferred and mentioned in one file. 🤷 . Next good example is #24218

Footnotes

  1. https://lists.openwrt.org/pipermail/openwrt-devel/2024-June/042933.html

@diizzyy
Copy link
Contributor

diizzyy commented Sep 24, 2024

I don't really see the issue with tar.xz tarballs especially since there have been lots of eyes on xz-utils since. Just grab whatever is the smallest tarball and go with it, it's not something other distros have enforced either to my knowledge.

@BKPepe
Copy link
Member

BKPepe commented Oct 2, 2024

No conclusion was made in the referenced PR (iputils), where it was also discussed. Closing.

@BKPepe BKPepe closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants