Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing "Not in HLO" ops from VHLO #1182

Closed
burmako opened this issue Feb 18, 2023 · 1 comment
Closed

Consider removing "Not in HLO" ops from VHLO #1182

burmako opened this issue Feb 18, 2023 · 1 comment
Assignees

Comments

@burmako
Copy link
Contributor

burmako commented Feb 18, 2023

Given that the "Not in HLO" ops are on their way out of StableHLO, I'm wondering if we should remove them from VHLO and fail when encountering them in stablehlo-legalize-to-vhlo requiring that these ops are lowered to core ops in the opset before being serialized.

@burmako
Copy link
Contributor Author

burmako commented Feb 19, 2023

Upon further thinking, this seems premature at this point. For better or for worse, these ops are part of StableHLO at the moment, so removing them from VHLO without any replacement would create an unnecessary friction point.

Once the ops are moved out of StableHLO (#3), we'll be able to deprecate and eventually remove them from VHLO using the regular process. #3 is part of the Frontend Contract workstream, which means that we're planning to get this done prior to releasing StableHLO v1.0.

@burmako burmako closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2023
@burmako burmako self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

1 participant