From f51fb6b49def62367bab54100310424b5f94da10 Mon Sep 17 00:00:00 2001 From: chentao <421224811@qq.com> Date: Tue, 2 Mar 2021 11:35:18 +0800 Subject: [PATCH] add detail and fix github-action --- .../20210301-enhancement_of_YurtHub_caching_ability.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/proposals/20210301-enhancement_of_YurtHub_caching_ability.md b/docs/proposals/20210301-enhancement_of_YurtHub_caching_ability.md index 6a7079786fb..0433bf544f1 100644 --- a/docs/proposals/20210301-enhancement_of_YurtHub_caching_ability.md +++ b/docs/proposals/20210301-enhancement_of_YurtHub_caching_ability.md @@ -164,7 +164,7 @@ Remove the restriction that only certain resources can be cached by removing [re #### Why the WithoutConversionCodecFactory loses GVK information -The reason why object misses the field of apiverison and kind is YurtHub using [serializer.WithoutConversionCodecFactory](https://github.com/alibaba/openyurt/blob/7095962687e2666a27d14e436b96ef893b228beb/pkg/yurthub/kubernetes/serializer/serializer.go#L48) as NegotiatedSerializer. Because the WithoutConversionCodecFactory is a CodecFactory that will explicitly ignore requests to perform conversion, the GVK information will be ignored when this WithoutConversionCodecFactory use the decoder (which is this [Decoder](https://github.com/kubernetes/kubernetes/blob/994b5c6cc20bda188ac9bc33217f2dbc7ecf45bb/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go#L256), the following is the old decoder's code). +The reason why object misses the field of apiverison and kind is YurtHub using [serializer.WithoutConversionCodecFactory](https://github.com/alibaba/openyurt/blob/7095962687e2666a27d14e436b96ef893b228beb/pkg/yurthub/kubernetes/serializer/serializer.go#L48) as NegotiatedSerializer. Because the WithoutConversionCodecFactory is a CodecFactory that will explicitly ignore requests to perform conversion, the GVK information will be ignored when this WithoutConversionCodecFactory use the decoder (which is this [Decoder](https://github.com/kubernetes/kubernetes/blob/994b5c6cc20bda188ac9bc33217f2dbc7ecf45bb/staging/src/k8s.io/apimachinery/pkg/runtime/helper.go#L256), the following is the old decoder's code). ```go // Decode does not do conversion. It removes the gvk during deserialization.