Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing speaker picture #144

Closed
rgaudin opened this issue Feb 27, 2023 · 3 comments · Fixed by #146
Closed

Missing speaker picture #144

rgaudin opened this issue Feb 27, 2023 · 3 comments · Fixed by #146
Assignees
@theparthshukla
Labels
bug
Milestone
2.1.0

Comments

@rgaudin
Copy link
Member

rgaudin commented Feb 27, 2023

In ZIMs created in #141, each videos from that playlist tries to display the speaker picture but the file is not in the ZIM

URL: videos/93770/speaker.webp while ZIM only has

  • videos/93770/thumbnail.webp
  • videos/93770/video.webm

Should we fail to retrieve the picture, we should just not display it at all. Given the filename has webp, it might have been fetched and converted but not added (or at incorrect location) to the ZIM
@rgaudin rgaudin added the bug label Feb 27, 2023
@theparthshukla
Copy link
Contributor

Can take this up!

1 similar comment
@theparthshukla
Copy link
Contributor

Can take this up!

@rgaudin
Copy link
Member Author

rgaudin commented Feb 27, 2023

It's yours

@theparthshukla theparthshukla mentioned this issue Mar 4, 2023
Merged
@kelson42 kelson42 added this to the 2.1.0 milestone Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theparthshukla theparthshukla

Labels
bug
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Update key for fetching speaker picture theparthshukla/ted
3 participants
@rgaudin @kelson42 @theparthshukla