-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for Youtube-hosted videos (videos not hosted on TED CDN) #164
Comments
https://www.ted.com/talks/william_sieghart_the_connective_potential_of_poetry has a null The fact is that in such a case, the scraper does not work. While the player on the web page fallback to a Youtube player as can be seen in screenshot below: Other videos hosted on TED CDN have a different player: This issue is then more about the support for Youtube-hosted videos when the TED one is not available. This impact many topics where some videos are missing because hosted only on Youtube. I'm currently running an evaluation of the big |
Btw, the Firefox vs Chrome/Brave situation is just a side-effect we should not care about, it is mainly a TED problem in fact ^^ |
In the |
Good to know ! |
I should have written "restore support for ...". It was working in the past, and most of the code is still there we just do not parse properly the video JSON data anymore. |
Good news then (I think) |
Very good yes, I just had to add a bit more stuff to align everything a bit better, you will see in the PR, but at least if was fast and easy. |
Thank you for your good remembering of how the scraper worked in the past, it definitely help (together with the usual |
See openzim/zim-requests#849 for details
The text was updated successfully, but these errors were encountered: