Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails should be internationalized #53

Closed
benoit74 opened this issue Apr 9, 2024 · 4 comments
Closed

Emails should be internationalized #53

benoit74 opened this issue Apr 9, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@benoit74
Copy link
Collaborator

benoit74 commented Apr 9, 2024

While #51 and #46 focused on the UI internationalization, it is clear that it is not sufficient, we must probably also internationalize the emails which are sent.

I suppose we should send the email in the language which was used by the user at the moment where the task was submitted.

@Popolechien do you confirm?

If this is confirmed, it means that translations should in fact be moved to Zimit Python/API codebase, in order to have only one set of strings to translate for TranslateWiki.

This is not a concern, and is in fact even probably a pretty good news since anyway the process of adding a new supported language is rather complex with only #51 work: in addition to creating the appropriate json file, one has to add the language to the combobox, to add the language to the supported language, and to edit the function computing whether the language is ltr or rtl

Moving all translations to Python would be a great opportunity to also automatize most of this process.

It also means that we have to store somewhere the UI language used when the user submitted the task, and since Zimit has no DB it probably has to be stored in contextual information of the requested task / webhook.

@Popolechien
Copy link
Contributor

Ah yes did not think about it but it is a very good point.

@rgaudin
Copy link
Member

rgaudin commented Apr 9, 2024

It can be stored in the webhook url

@benoit74
Copy link
Collaborator Author

benoit74 commented Apr 9, 2024

It can be stored in the webhook url

Indeed, good point

@benoit74
Copy link
Collaborator Author

Closing this in favor of #76, code is ready and deployed. Language is stored in webhook, i.e. the language the user was using when he submitted the request will be the one used in emails he will receive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants