Fix LedgerConnector initialization #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @mikeshultz it works for me now. When Logged in with Ledger the balances and allowances are correctly being loaded. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I should have noticed these issues in my testing. Though I'm still not able to properly test this because my local environment is fucked(contract deploys not happening?) and I'm not sure why. The initialization of the connector succeeds now but I can't test contract calls yet because contracts aren't able to initialize on my local. The RPC calls that were failing before are now fixed.
This fixes the W3PE subprovider initialization so the RpcSubprovider is now available when the LedgerProvider is being initialized(for balance checks).
@sparrowDom give me a shout when you're around again today?