mvc: Macro 'base_dialog_header' is already defined on PHP 7.0

[fichtner]

Suboptimal workaround introduced for a problem exclusive to PHP 7.0 is 8f194f4 .

Maybe there is some underlying bug that doesn't visibly trigger on PHP 5.6 or we just need to find a better way to keep the former readability intact.

Thanks!

[fichtner]

This resurfaced now, we should just avoid the macro here...

https://forum.opnsense.org/index.php?topic=4860.0
6d7d2dc

[fichtner]

or alternatively make it a full template to be included

[AdSchellevis]

new phalcon version?

[fichtner]

could be, although we should really go with the flow here, php 7.0 scoping and phalcon will likely not get better when nobody cares as it would seem ;(

[fichtner]

I saw this just once while testing a few minutes ago, after that the thing works as normal. I've prodded the 3.0.4 phalcon release for over two weeks....

[fichtner]

Sorry for pinging this all the time, small valuable addition: the reporter said this happened for him on a fresh 17.1 install as well today, so it may be circumstantial race condition we could not possibly fix or report upstream

[AdSchellevis]

really a bummer, the volt templates seem to get more broken on every release.... scope issues, macro issues, ....
Let's revert and hope it won't get worse...

[fichtner]

Agree. I'll get confirmation from the reporter, then try to fix this a bit more pretty

[fichtner]

created a ticket just for reference... phalcon/cphalcon#12744

[AdSchellevis]

thanks!

[fichtner]

Ok, that's the one phalcon/cphalcon#12648

[sergeyklay]

Fixed phalcon/cphalcon#12782

[fichtner]

@sergeyklay many thanks! 👍