Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[provisioner/shell] it works #286

Closed

Conversation

ChrisLundquist
Copy link
Contributor

This was mostly for me to learn about how provisioners work in modern test-kitchen.
It also might be a poor man's way to support puppet.


# XXX Not implementing this will upload '/*' to each host
# Or try, and die on resolving bad symlinks
def create_sandbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I have a bit of logic to account for in Kitchen::Driver::SSHBase, will look

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I wrote the above comment, I saw /Applications/Adium... uploaded to the VM, then saw this line. I could have easily over looked something. I just saw "#{nil}/*" and chalked it up to that.

@fnichol
Copy link
Contributor

fnichol commented Dec 19, 2013

This is looking pretty good! In post-1.0.0 releases, there is a data_path option (defaulting to test/integration/<suite>/data/, test/integration/data/, or './data/) that will upload all contents to the instance, available at/tmp/kitchen/data` by default. this could be a way to get some test or provision-related code onto the remote host. I'm going to have a play with this--it's a nice gentle start into non-Chef provisioners 👍

@ChrisLundquist
Copy link
Contributor Author

Hmm, I only see data_path in ChefBase

$ grep -r "data_path" lib/
lib//kitchen/provisioner/chef_base.rb:      default_config :data_path do |provisioner|
lib//kitchen/provisioner/chef_base.rb:        config[:data_path]

The config block uses provisioner.calculate_path('data')

In #291 I moved calculate_path to Base from ChefBase. It seemed like calculate_path did what you mentioned.

Yeah, using a calculate_path to find bootstrap.sh would be better. We can fix it up here and I can update the other PR as well if we conflict.

@ChrisLundquist
Copy link
Contributor Author

This should implement the path lookup change you mentioned above.
I pulled a commit from my other PR to avoid merge conflicts.
TravisCI tests seem to be occasionally timing out on a cucumber spec.

@ChrisLundquist
Copy link
Contributor Author

added in cc44abe

@fnichol
Copy link
Contributor

fnichol commented Dec 20, 2013

For the benefit of others, @ChrisLundquist and I had a great chat tonight and combined the first commit in this PR with some work in #298 to make Kitchen::Provisioner::Base smarter and more general purpose.

@ChrisLundquist ChrisLundquist deleted the shell-provisioner branch December 20, 2013 06:31
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants