-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[provisioner/shell] it works #286
[provisioner/shell] it works #286
Conversation
|
||
# XXX Not implementing this will upload '/*' to each host | ||
# Or try, and die on resolving bad symlinks | ||
def create_sandbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I have a bit of logic to account for in Kitchen::Driver::SSHBase
, will look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I wrote the above comment, I saw /Applications/Adium...
uploaded to the VM, then saw this line. I could have easily over looked something. I just saw "#{nil}/*"
and chalked it up to that.
This is looking pretty good! In post-1.0.0 releases, there is a |
Hmm, I only see
The config block uses In #291 I moved Yeah, using a |
This should implement the path lookup change you mentioned above. |
added in cc44abe |
For the benefit of others, @ChrisLundquist and I had a great chat tonight and combined the first commit in this PR with some work in #298 to make |
This was mostly for me to learn about how provisioners work in modern test-kitchen.
It also might be a poor man's way to support puppet.