Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A doc example of D4sigma seems to call Centroid instead of D4sigma #74

Open
gimli2 opened this issue Jul 10, 2023 · 1 comment
Open

Comments

@gimli2
Copy link

gimli2 commented Jul 10, 2023

It seems that there is a typo on this line:
https://github.com/opticspy/lightpipes/blob/master/LightPipes/core.py#L115C9-L115C29
There is Centroid(F) instead of Sigma(F).

Probably it should look something like this:

from LightPipes import *
wavelength = 500*nm
size = 25*mm
N = 500
F = Begin(size, wavelength, N)
F = CircAperture(F, 2*mm, x_shift=5*mm, y_shift=3*mm)
F = Fresnel(F, 10*m)
sx, sy = D4sigma(F)
@FredvanGoor
Copy link
Member

Yes, you are right! I will change it.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants