Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] [question] Is optimizely virtual thread / loom friendly? #537

Closed
wyhasany opened this issue Feb 22, 2024 · 6 comments · Fixed by #540
Closed

[ENHANCEMENT] [question] Is optimizely virtual thread / loom friendly? #537

wyhasany opened this issue Feb 22, 2024 · 6 comments · Fixed by #540
Labels
acknowledged The issue has been acknowledged and being looked into. Further details will follow.

Comments

@wyhasany
Copy link
Contributor

Description

I wonder if optimizely is loom-friendly - e.g. does not pin the platform threads? I can see that you hardcode underneath platform thread, I would like to replace it with virtual one, currently I can do it only with nasty reflection

Benefits

Users of sdk can use its resources effectively. The very same goes for reactive apps.

Detail

No response

Examples

No response

Risks/Downsides

No response

@wyhasany
Copy link
Contributor Author

I can see there is a bunch of synchronized methods which could be synchronized with ReentrantLock

@jaeopt jaeopt added the acknowledged The issue has been acknowledged and being looked into. Further details will follow. label Feb 23, 2024
@jaeopt
Copy link
Contributor

jaeopt commented Feb 23, 2024

@wyhasany thanks for your feedback! We do not support loom yet. Can you submit your feedback here for our future consideration?

@wyhasany
Copy link
Contributor Author

wyhasany commented Feb 23, 2024

@jaeopt What a product should I choose? Am I reaally need to do that? To allow support of loom you need to allow to inject external executor service and replace synchronized blocks with ReentrantLock.

@wyhasany
Copy link
Contributor Author

@jaeopt any updates?

@jaeopt
Copy link
Contributor

jaeopt commented Mar 11, 2024

@wyhasany You can submit a ticket for "Feature Experimentation" > "SDKs and Agent" in the link above. Not clear what we should change in the SDK to support Loom. We'll look into it. If you want, you can also consider to submit a PR for the enhancement with backward compatibility for Java8+.

@jaeopt
Copy link
Contributor

jaeopt commented Apr 12, 2024

@wyhasany A new release (4.1.0) includes your PR to add this feature. Let us know if it works good for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged The issue has been acknowledged and being looked into. Further details will follow.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants