Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement (OptimizelyExperiment): Clarify expected usage of default and log violations #37

Open
jamesopti opened this issue Mar 17, 2020 · 1 comment
Open

enhancement (OptimizelyExperiment): Clarify expected usage of default and log violations #37

jamesopti opened this issue Mar 17, 2020 · 1 comment
Labels
acknowledged enhancement New feature or request

Comments

@jamesopti
Copy link
Contributor

jamesopti commented Mar 17, 2020 •
edited
Loading

Summary

The <OptimizelyExperiment> component makes some assumptions about the children prop that we should document and warn about:

  • Exactly 0 or 1 <OptimizelyVariation default > child components should be passed
  • If 1 is passed, ensure it is the last child in the list
    • Upon finding one, the loop short circuits because it has found a match
@jamesopti jamesopti added the enhancement New feature or request label Mar 19, 2020
@Tamara-Barum
Copy link

Internal Ticket: [FSSDK-8657]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jamesopti @Tamara-Barum @mikechu-optimizely