-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OracleRestDataServices/dockerfiles/buildDockerImage.sh oracle/serverjre:8 Issue #646
Comments
This is a good discussion to have, hence assigning to @Djelibeybi. As we already have the jdk on the hub itself, why can't we just use that one directly: https://hub.docker.com/r/oracle/openjdk/ |
Also, how do we overcome the different naming conventions? For those images on the container-registry that are built using those build files on Github, why not just keep the same label? |
@gvenzl if we can use the hub image even better. But something is still wrong as I manually pulled the |
The idea was that all the GitHub images work together. However, I think there is possibly some scope for adjusting the instructions here on GitHub to match the naming we have on Oracle Container Registry. |
Hey @Djelibeybi, I was actually referring to the image that we provide on the Docker hub itself and not on the container store: https://hub.docker.com/r/oracle/openjdk/ Given that we have a fully open source image of Oracle Linux and OpenJDK I see no reason to have to push users through an additional click-through just to download it from the container-registry when all we need is the JDK on OL. |
Only issue is that ServerJRE is different than OpenJDK. They are not exactly the same thing. Commercial support for ORDS is provided when running on Oracle Java (e.g. ServerJRE) |
I suppose the answer to this then is: The build files on Github depend on each other, i.e. one has to build the Java image first before building the ORDS image. The images on the container-store depend on each other, i.e. the upcoming ORDS image will pull the serverjre from the container-registry as prerequisite. @Djelibeybi, @brunoborges do you guys agree? |
The specifics are slightly different in that the GItHub ORDS image would share layers with the Java image, while the Container Registry ORDS image shares similar layers with the Java image from OCR. But that's close enough for me to agree with you. |
Note: my copy of
buildDockerImage.sh
was updated to get around agawk
issue in macOS. The version I am running is in PR #645 (fixing issues #644)When I run
cd docker-images/OracleRestDataServices/dockerfiles ./buildDockerImage.sh -i
I get:
If I then run the following to confirm no container registry issues
docker login container-registry.oracle.com # And run docker pull container-registry.oracle.com/java/serverjre
If I run
./buildDockerImage.sh -i
again I get the same error as initial shown.The text was updated successfully, but these errors were encountered: