From a2f177c1853e87e01e3492227176bfd217f7bbfa Mon Sep 17 00:00:00 2001 From: wangxiaoxuan273 Date: Wed, 4 Jan 2023 09:22:35 +0000 Subject: [PATCH 1/2] fix: should return empty manifest list when no referrers are found Signed-off-by: wangxiaoxuan273 --- registry/handlers/referrers.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/registry/handlers/referrers.go b/registry/handlers/referrers.go index 26f5f9823d4..a267c14966f 100644 --- a/registry/handlers/referrers.go +++ b/registry/handlers/referrers.go @@ -67,6 +67,9 @@ func (h *referrersHandler) GetReferrers(w http.ResponseWriter, r *http.Request) } } referrers, err := h.generateReferrersList(h, h.Digest, artifactTypeFilter) + if len(referrers) == 0 { + referrers = []v1.Descriptor{} + } if err != nil { if _, ok := err.(distribution.ErrManifestUnknownRevision); ok { h.Errors = append(h.Errors, v2.ErrorCodeManifestUnknown.WithDetail(err)) From 9ecbf34a5605b12a9eb492174bae501acc2ad142 Mon Sep 17 00:00:00 2001 From: wangxiaoxuan273 Date: Thu, 5 Jan 2023 09:06:09 +0000 Subject: [PATCH 2/2] addressed the comments Signed-off-by: wangxiaoxuan273 --- registry/handlers/referrers.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/registry/handlers/referrers.go b/registry/handlers/referrers.go index a267c14966f..c5ffb6430b6 100644 --- a/registry/handlers/referrers.go +++ b/registry/handlers/referrers.go @@ -67,9 +67,6 @@ func (h *referrersHandler) GetReferrers(w http.ResponseWriter, r *http.Request) } } referrers, err := h.generateReferrersList(h, h.Digest, artifactTypeFilter) - if len(referrers) == 0 { - referrers = []v1.Descriptor{} - } if err != nil { if _, ok := err.(distribution.ErrManifestUnknownRevision); ok { h.Errors = append(h.Errors, v2.ErrorCodeManifestUnknown.WithDetail(err)) @@ -79,6 +76,10 @@ func (h *referrersHandler) GetReferrers(w http.ResponseWriter, r *http.Request) return } + if referrers == nil { + referrers = []v1.Descriptor{} + } + response := v1.Index{ Versioned: specs.Versioned{SchemaVersion: 2}, MediaType: v1.MediaTypeImageIndex,