Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

health endpoint #51

Open
shankj3 opened this issue May 31, 2018 · 1 comment
Open

health endpoint #51

shankj3 opened this issue May 31, 2018 · 1 comment

Comments

@shankj3
Copy link
Collaborator

shankj3 commented May 31, 2018

create health endpoint for all ocelot services that has at least:

{
    "status":"OK",
    "description": "",
    "serviceName": "poller",
    "version": "",
    "startTime": "",
    "dependencies": [
      {
         "name": "postgres",
         "url": "dbconnectionurl here: postgresIp:postgresPort",
         "status": "Green",
         "significance": "if unreachable, no new builds would be triggered",
         "lastUpdated": "2018-02-08T00:21:34+0000"
      },
     {
         "name": "nsq",
         "url": "http://nsq.io",
         "status": "Green",
         "significance": "if unreachable, no new builds would be triggered",
         "lastUpdated": "2018-02-08T00:21:34+0000"
      },
    ]
}
@tjtelan
Copy link
Member

tjtelan commented Jun 14, 2019

I go back and forth with this, since it is a L11 pattern to have health endpoints. But with Kubernetes splitting health into "healthy" and "ready", I would rather have something that makes that easier.

For now, I'd rather use Consul/Kubernetes to do the health checks. We can go back to thinking about dependency health checks later when things are detangled.

@tjtelan tjtelan added this to the After API redesign milestone Jun 14, 2019
@tjtelan tjtelan removed this from the After API redesign milestone Jul 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants