Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Improperly comparing CIDs #90

Open
vaultec81 opened this issue Apr 9, 2020 · 0 comments
Open

Improperly comparing CIDs #90

vaultec81 opened this issue Apr 9, 2020 · 0 comments

Comments

@vaultec81
Copy link
Contributor

CIDs/multihash can be encoded in many different formats. base58btc, base32, etc. Comparison via normal javascript methods do not work. Use CID.equals(CID2) instead.
https://github.com/orbitdb/orbit-db-store/blob/1b628b6a9035e2b0fda2f68052797c6b0a0a74b4/src/Store.js#L302-L304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant