Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map-util buttons such as the geocode search bar, zoom buttons etc #5

Open
GarrySan opened this issue Mar 25, 2020 · 9 comments
Open

Comments

@GarrySan
Copy link

No description provided.

@ivanoats
Copy link
Member

Hey, it's awesome that you're forging ahead on this, but I wanted to plan out some architecture before the features. Have a look at https://xstate.js.org/viz/ - this is what I wanted to use. I can lay out more of the planning thinking in a separate issue, and also jump into #orcmap-react channel on Slack please.

@GarrySan
Copy link
Author

Sure thing @ivanoats . xstate looks super cool!

@parthsarthiprasad
Copy link
Contributor

@ivanoats I was thinking something like a sidebar to acess all the buttons. following react-hooks and https://xstate.js.org/viz/ . Can i go forward with this approach? Will try to open a PR for this.

@ivanoats
Copy link
Member

ivanoats commented Mar 20, 2021

neat stuff but what features is this being driven by? The buttons from the original map? We need a more complete user story before deciding to work on it, I think.

@parthsarthiprasad
Copy link
Contributor

parthsarthiprasad commented Mar 20, 2021

image
From the original Map

In both ways this is the task which will require some work, using sheets API to acquire new data and plot those points on the graph

  • Open google sheet (can be done easily with an href)

Further functionality can be added into this after completing these basic blocks

Expected time : 2-3 hours

Do let me know about your suggestions @ivanoats thanks.

@DhananjayPurohit
Copy link
Member

A state machine for the above case can be :-

Screenshot (156)

link to above visualization.

I am new to XState, but we can bring out more ideas through discussion. Any suggestions? @ivanoats

@ivanoats
Copy link
Member

Makes sense 👍🏼 Thanks for diagramming that.

What service provides Authorization?

@DhananjayPurohit
Copy link
Member

DhananjayPurohit commented Mar 29, 2021

I think Authorizing a user with Google's OAuth 2.0 with giving access to writing into spreadsheet will hold good instead of setting a service account(a bot to write into spreadsheet) to ensure authenticated entries only. It can be easily implemented using google-spreadsheet(the same package we are using for getting data from spreadsheet). Here's the link to the documentation of implementation(https://theoephraim.github.io/node-google-spreadsheet/#/getting-started/authentication).
Authorization is only for the users who want to add markers(observations) to spreadsheet.

@Devesh21700Kumar
Copy link
Contributor

Makes sense 👍🏼 Thanks for diagramming that.

What service provides Authorization?

Oauth 2 pipeline by google would be the best case for authorization.
The server side for the applications that might control the Google sheets can use JWT or some other middleware suitable for the tech stack used for it to verify the token generated in the OAUTH pipeline and frontend could receive it as response and maneuver it by setting it in localstorage.

This can also lead to addition of extra features i suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants