Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for SMTP access #2

Open
richardgavel-ordinaryexperts opened this issue Feb 23, 2023 · 1 comment
Open

Updates for SMTP access #2

richardgavel-ordinaryexperts opened this issue Feb 23, 2023 · 1 comment

Comments

@richardgavel-ordinaryexperts
Copy link
Contributor

richardgavel-ordinaryexperts commented Feb 23, 2023

Environment variables should be set for DISCOURSE_SMTP_ADDRESS, DISCOURSE_SMTP_USER_NAME, DISCOURSE_SMTP_PASSWORD.

Also think that SES construct could stand to be more clear. The IAM user, even though it's created by the specifically by the SES module, is named {region}-{stack}-instance. This seems like a vague name. Also, consumers of the secret only need the username and password. The secret access key should not need to be in the secret, and a more clear key name would be "smtp_username" as opposed "access_key_id".

Looking at the existing SES construct, it feels like every child resource created by it is exposed as a property. This makes things difficult to know what information from it is critical (too much exposed). You have to know the name of the generated secret to consume that information. The ID of that secret should be exposed as a property.

The lack of the information regarding the SES secret also makes it tricky because we have to inject the ARN of the credentials secret into the Asg construct to allow the EC2 access to it.

Might also be useful to add a VPC endpoint. See here (aws/aws-cdk#9386)

@richardgavel-ordinaryexperts richardgavel-ordinaryexperts changed the title Update user data to include SMTP info Updates for SMTP access Feb 23, 2023
@richardgavel-ordinaryexperts
Copy link
Contributor Author

richardgavel-ordinaryexperts commented Aug 18, 2023

Also needs a verified identity for the "DISCOURSE_DEVELOPER_EMAILS" settings.

TODO: List of comma delimited emails that will be made admin and developer
on initial signup example '[email protected],[email protected]'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant