Java 21

[mokun]

@bevans2000 @Urwumpe

Is there anything that may hold us back from transitioning into Java 21 ?

[bevans2000]

It might not be widely adopted yet. I don't see any benefit to us yet.

[mokun]

Things are getting interesting in the new Eclipse 4.32, namely Eclipse IDE 2024-06.

It just got release today as of June 12th.

Unfortunately, it would require Java 21.

The good news is that it has by default checked box that will download/update Java to version 21 automatically.

See https://www.eclipse.org/setups/sponsor/?scope=Eclipse%20IDE%20for%20Java%20Developers%20(includes%20Incubating%20components)&version=4.30.0.20231201-1200&campaign=2024-06.

Perhaps it's about time for us to move onward to Java 21 as it was released back in 19 September 2023.

[bevans2000]

Let's do it in 3.9.0

[mokun]

About time for mars-sim move onto Java 21 in light of the requirement of that for Eclipse IDE Jun 2024 version.

[mokun]

I'll download [Eclipse IDE Sep 2024 to try out its new features.

[bevans2000]

Yes why not. Switch type pattern matching would be great. It's only preview in java 17.

You will have to change the maven pom and git actions. Create an issue and we create a branch to do the change in isolation first

[mokun]

Create an issue and we create a branch to do the change in isolation first

I found no issues at all in switching over to Java 21 in the master branch.

Just tested it.

Nothing to resolve. We can do it now, rather than later.

[mokun]

I can see the new branch in my browser as follows:

[mokun]

The file "/.gitignore" im mars-sim has the followings:

/build
**/target/
.classpath
.project
/.settings/**
.idea
.prefs
/mars-sim.iml
.vscode

It doesn't filter off any *.yml files.

I don't know why yml files won't get uploaded.

[mokun]

Eclipse provides the following explanation:

refusing to allow a Personal Access Token to create or update workflow .github/workflows/codeql-analysis.yml without workflow scope

I'm reading this page and elsewhere for a solution.

[bevans2000]

Sounds like your access_token in git did not have the full rights when you created it. You cannot update them so either create a fresh one or just push your pom changes and I can do the actions tomorrow on that branch.

[mokun]

Sounds like your access_token in git

RIght. My PAT is bad.

Earlier, I manually edited each yml files. After that, I found out those yml files are in master branch and not the pre-3.9.0_java21 branch. I did the change on the wrong branch.

Anyway, everything looks okay without any hiccups.

I merged the rest of the change from that branch to the master branch.

We've successfully switched to Java 21 now.