v3.8.x Goals

[mokun]

Currently, we have 38 open issues for v3.8.0. See https://github.com/mars-sim/mars-sim/milestones/3.8.0?page=2&q=is%3Aopen+milestone%3A3.8.0

Let's go rack and stack them first.

[bevans2000]

Sure let's focus on the tagged issues first

[bevans2000]

We need to improve the SonarQube results; recently the figures have gone significantly worse. I looked last night and there is an increase in commented out. Let's just remove it.
Set the goal of zero bugs.

[mokun]

So which one are you interested in working on ?

[mokun]

For me, my priority is fixing issues with construction missions so that a settlement may expand by having more more in-situ based buildings.

I'd like to assume that those brick-like buildings from the mining and trading outpost templates be treated as the first generation Mars-made buildings.

After a while, when the level of manufacturing capability is reasonably caught up, we may allow settlers to build hab-like buildings that are being sent to Mars.

We can even assume Earth's technological level of maturity in near terms will be always one step ahead of Mars. These advanced buildings may be made on the Moon and be shipped to Mars.

[bevans2000]

That makes sense as Construction is important.
I will just work in the issues assigned to the milestone, probably #973 first.
Going to clean up the code in the console module as well

[mokun]

@bevans2000

Currently, we have 25 open issues and 24 closed issues under [3.8.0](See https://github.com/mars-sim/mars-sim/milestone/15).

Which ones would you like to finish and which ones to push to later release ?

[mokun]

@Urwumpe

Would you like to name what feature you most want ?

Which one or two issues would you like to get resolved ASAP ?

[bevans2000]

I will be closing #1285 today via a PR. I'm working on #274 but it's a bit of a bigger problem.
#1094 must be done by now?
I think 3.8.0 is full enough now and would just push the other to 3.9.0 BUT the latter would need a re-planning and some bigger ones going to 4.0

[bevans2000]

I think we need to close 3.8.0 soon. I would like to close #1315.
In 3.9 we focus on the new Mission pattern?

[bevans2000]

Release number in poms need updating

[bevans2000]

Actually I have updated the release page in the wiki. I will update it this weekend

[bevans2000]

Wiki page updated https://github.com/mars-sim/mars-sim/wiki/Release-Procedure

[mokun]

In the past, I need to first generate a new set of HTML files and manually copy them from the target folder to the src folder. I don't think this step is automatic yet, right ?

Then I'll need to compile the binaries on my own machine and manually upload it to GitHub's new release page. Is this step already done away with ?

[bevans2000]

No that's all in the past. Look at the wiki page for release and that explains it. Basically create a tag and then push it. Then a specific Action will fire to built it and create a draft Release.

[bevans2000]

@mokun A few of the new recent UnitTests are randomly failing when run from GitHub. Locally they are running fine.
I'm trying to work through the problems but it's hard to understand why they fail

[bevans2000]

I think I've improved the situation with c95afe7
Committed to master

[mokun]

It looks like some BuildingPanel* (such as BuildingPanelPower and BuildingPanelThermal) suffers from the shortening of the title description on the top :

On the other hand, BuildingPanelResourceProcessing has a longest title. Yet it's not affects by it.

Why ?

[bevans2000]

That's odd

[mokun]

I just found out another scenario in which the title text, for instance, "Power Grid", would turn into its short form "Power Gr...".

When I drag the whole main window from my external monitor back to the built-in LCD of my laptop., it automatically turn into its short terms. It's as if Flat LAF calculate the size of the text to try to fit in.

It sounds it's over-doing it as if it's like a bug.

[mokun]

Are you still working on #1329 ?

Finish it before releasing 3.8.0 ?

Turns out we did not work on Construction at all for 3.8.0.

[bevans2000]

Yes, I will commit something at weekend

[bevans2000]

What's left to do then in 3.8.0?

[Urwumpe]

How about maintaining a task board with the official goals and needed tasks for calling a release finished?

[bevans2000]

How about maintaining a task board with the official goals and needed tasks for calling a release finished?

We have the Milestone in Issues and that should be the driving force. I believe it is now empty for 3.8.0, hence my question.
Anything we do should be tracked back to an issue

[mokun]

There's still a resource imbalance problem.

The methane will run out in about 20 sols for some settlements.

I've tried a few ways to avoid that but it still happens.

Since most buildings has to burn methane for heating , I'm going to investigate the rate and how much it's used for that.

Any insights ?

[mokun]

In terms of mission balance, it seems there's a crazy # of regolith prospecting missions starting.

However, there are very few or no field missions.

There are some exploration missions. But not enough.

Rarely any mining missions taking place. Btw, Can you check if mining missions still have bugs ?

[mokun]

In v3.9.0, I'd like to pave the way for road constructions and building transportation hubs such as train stations, etc., in addition to weather stations and communication towers.

[bevans2000]

I suggest you create a Project with a set of steps to get what you want. Must use some branching if these are big changes.
I want to focus on the concurrency issue when Trade and Delivery missions, we have an issue.
Then work on the generic Mission approach

[bevans2000]

I also have an idea about changing how we capture metrics and centralise that.

[bevans2000]

In terms of mission balance, it seems there's a crazy # of regolith prospecting missions starting.

However, there are very few or no field missions.

There are some exploration missions. But not enough.

Rarely any mining missions taking place. Btw, Can you check if mining missions still have bugs ?

I think we focus on the new project based approach unless it breaks

[mokun]

I try running HelpGenerator but it throws me error :

C:\Users\mkhelios\eclipse\java-2024-06\git\mars-sim\mars-sim\mars-sim-tools\src\main\java\com\mars_sim\tools\helpgenerator>java com.mars_sim.tools.helpgenerator.HelpGenerator ../mars-sim-ui/src/main/resources/docs/help/generated    
Error: Could not find or load main class com.mars_sim.tools.helpgenerator.HelpGenerator
Caused by: java.lang.ClassNotFoundException: com.mars_sim.tools.helpgenerator.HelpGenerator

[mokun]

Instead of mars-sim-ui, may be you mean to say

/mars-sim-tools/src/main/resources/help/generated ?

[bevans2000]

I try running HelpGenerator but it throws me error :

C:\Users\mkhelios\eclipse\java-2024-06\git\mars-sim\mars-sim\mars-sim-tools\src\main\java\com\mars_sim\tools\helpgenerator>java com.mars_sim.tools.helpgenerator.HelpGenerator ../mars-sim-ui/src/main/resources/docs/help/generated    
Error: Could not find or load main class com.mars_sim.tools.helpgenerator.HelpGenerator
Caused by: java.lang.ClassNotFoundException: com.mars_sim.tools.helpgenerator.HelpGenerator

You can't run it like that. It is like any other of our main classes and needs to other classes and libraries. There is a launcher file I think

[bevans2000]

Instead of mars-sim-ui, may be you mean to say

/mars-sim-tools/src/main/resources/help/generated ?

No because we do.not commit the generated file to got any more.

[bevans2000]

Can you see if you can run it to produce the html pages ?

Also, is the destination supposed to be inside the folder called generated ?

I suppose that folder will be created, right ?

I have made some changes to manufacturing.xml and resources.xml, etc.,

Q: do I need to run it manually in order for it to produce a new set of htmls prior to each release ?

I documented the new approach on the commit. The html is generated on demand when the help tool is used from the UI. It auto generated based on the release number.
But if you want to force a regenerate then delete the docs folder inside the local.mars SIM folder

[mokun]

You can't run it like that. It is like any other of our main classes and needs to other classes and libraries. There is a launcher file I think

There's that generate-help.md file you put inside mars-sim-tools. It tells me to run it that way.

To generate the UI help use the Help Generator tool contained within. It takes a single argument that is the target directory.

> java com.mars_sim.tools.helpgenerator.HelpGenerator ../mars-sim-ui/src/main/resources/docs/help/generated

[mokun]

The html is generated on demand when the help tool is used from the UI. It auto generated based on the release number.

So when you say "generated on demand", do you mean that during the simulation, if I click on a process, it will give me the specs for that process.

Behind the scene, a temporary html file is generated and be read and converted into a tooltip in Swing UI ?

[mokun]

I'm re-reading #1260 now to understand what's been changed.

[mokun]

We can release 3.8.0 now if there's nothing else critical to fix.

[bevans2000]

When will 3.8.0 be closed off?

[mokun]

When will 3.8.0 be closed off?

Say after we finish these 2 :

1. Unable to open Lander Hab's building unit window #1371
2. Unable to promptly perform On-Duty task #1372

It doesn't seem we can resolve this:

1. Crewmembers teleported. Vehicle stuck. A Crewmember having a medical emergency  #1356

[bevans2000]

#1371 yes I totally agree. I will look at this next
#1372 I'm not sure about this because it fundamentally changes how we select Task but let's discuss in the issue

#1356 I have an idea how to trap this when it happens.

[mokun]

#1356 I have an idea how to trap this when it happens.

May I ask in what ways ?

[bevans2000]

#1356 I have an idea how to trap this when it happens.

May I ask in what ways ?

Check in the transfer method that the vehicle is in a Settlement when a Person is transferred to a Settlement

[bevans2000]

Only #1372 is left but we should leave that as it's a simple change so let's leave it out. So can we close 3.8 down now?
I feel we are just messing around now.

[mokun]

Also, there's a README.txt file in the root folder.

Do we want to rename it to something else ?

We already have a file called README.md (in the mars-sim folder) that GitHub would use as the first page when loading https://github.com/mars-sim/mars-sim/, right ?

[mokun]

I just created a 3.8.x branch for potential bugfixes.

[bevans2000]

Done !
I've released v3.8.0 the old fashion way.
I wasn't using git directly to trigger a release since I don't have the git command line configured and not sure about how to use eclipse IDE to push differently. Will try it next time.

One thing I just notice is that v3.8.0 Swing Jar is 75 MB (vs. v3.7.2's 59MB).

Not sure why it's that big.

Do you want to pull the v3.8.0 back and skim off whatever made it so bloated ?

The large JAR is because you added more map images files to the resources/map folder and these get bundled into the JAR. We added the download maps feature to solve this problems; only the minimum map were added to the JAR.

[bevans2000]

Also, there's a README.txt file in the root folder.

Do we want to rename it to something else ?

We already have a file called README.md (in the mars-sim folder) that GitHub would use as the first page when loading https://github.com/mars-sim/mars-sim/, right ?

This is the README.txt that will be installed as part of the deployment; it's not used by GitHub.

[bevans2000]

Also, I just discovered that a GitHub Action was somehow triggered, which leads to creating another entry called Release v3.8.0. It's still in Draft form, awaiting for finalizing it.

Correct, the actions triggers on a tag of the correct format being created. The objective was to remove having to compile locally and then uploading the artefacts because this has the risk that a local change not commit may get added.

Should we give the player the choice to download the jar file they want ? instead of having both jarfiles in one big download ?
Yes we decided to have a single download ZIP which contains scripts for both Linux & Windows as a single download. It makes more sense and is easier.

[mokun]

It seems the resolution level switching issue in Mars Navigator is finally being identified and fixed.

What else would you like to include in 3.8.1 ?

[mokun]

But I don't know if I could make adjustment to the landmark text color in time but will try.

Would you like to try tackling on backlog tasks choice ?

[bevans2000]

Usually a point release is used for fixing bugs uncovered since a release was done. So I see no need to pick anything off the backlog.
I'm working on completing #1324.

[mokun]

Usually a point release is used for fixing bugs uncovered since a release was done.

Right.

The loading/unloading issue was there all along. It's not trivial and requires design change, right ?

[bevans2000]

Sorry, #1324 is on the master branch for 3.9

[mokun]

@bevans2000 @Urwumpe @muybien3433

Anything you see in 3.8.0 that needs to be fixed and include in 3.8.1 ?