Tool-bar plugin icons not scaling

[croaker000]

Pulsar 1.107.1, Tool-bar 1.4.4 plugin

With this release, the toolbar icons no longer scale when the toolbar icon size is changed. The tool-bar width does change, the icons stay the same size. Was fine in 1.106

[Daeraxa]

This is probably down to the less upgrade and the requirement for parens-division, there are lines like this:
https://github.com/atom-community/tool-bar/blob/6ec4827551ef374fd796787d7283d001d38b84d4/styles/tool-bar.less#L145C11-L145C11
Which I'm guessing are causing the issue, as far as I know Pulsar should be trying to fix this on the fly - @confused-Techie do we need this as a bug or is this being tracked already?

[confused-Techie]

So looking at this again, seems there's a new line causing the failure.

Here we can see an interesting construct:

&.tool-bar-24px {
  .tool-bar-size(24px * 2);
}

Now, I'd have to double check, but if memory serves, this won't be caught by the Less compatibility "Transform Deprecated Math Usage in Less Stylesheets" setting, because it's already enclosed in parenthesis. Which when I drafted that feature up, I had thought anything in parenthesis would be handled by less automatically.

But since this is a call to another function of this Less style sheet, I suppose it's not. Since this snippet results in the following CSS:

.tool-bar.tool-bar-24px .tool-bar-btn:before {
  font-size: 48px / 2;
  line-height: 48px;
}

Which, is obviously invalid. The hard part is I'm not sure what's best to do about this, because we can't have the "Transform Deprecated Math Usage" effect everything, even if in parenthesis', since that would begin to break some functions, I'd imagine, the biggest concern being that it would match on things it's already upgraded, causing the time to transform a single file would increase.

So yeah, this one is a little hard to say. The best thing to do, may be just to actually fix the less code itself, unless someone can think of how we can force this package to work on newer versions of less.

Although, I will say, this package is from atom-community we could look into forking it and having it official supported under Pulsar.

[confused-Techie]

Must have looked at this too fast.

Looking again, this is in fact the line causing the error.

Which makes much more sense when considering the final CSS that's output. Although, this should absolutely be caught as something that should be fixed.

So once I'm able I'll try to run some additional tests

[croaker000]

Not sure if this helps but changing line 145 of tool-bar.less to

font-size: @size * 0.5;

Seems to have done the trick.

[gabriel-xlab]

Following @croaker000, for text based buttons you should also change for the remaining lines:

    .tool-bar-btn {
      height: @size + (@button-border-size * 2);
      min-width: @size + (@button-border-size * 2);
      &:before {
        font-size: @size * 0.5;
        line-height: @size;
      }

      &:not(:empty) {
        font-size: @size * 0.5;
        line-height: @size;
        padding: 0 @size * 0.25;
        &:before {
          padding-right: @size * 0.25;
        }
      }

[thatcomputerguy0101]

I notice there is now a fork of this package under the pulsar-edit organization, but with no commits beyond the original repo. Is it being taken on as a pulsar package? I would be willing to create a PR somewhere to help fix this, but I'm unsure where I should do so.