-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): add field and value matchers to the commit parser #312
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️ |
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! Just had some suggestions for improving the code.
Also, can you resolve the conflicts with |
Co-authored-by: Orhun Parmaksız <[email protected]>
Co-authored-by: Orhun Parmaksız <[email protected]>
Co-authored-by: Orhun Parmaksız <[email protected]>
Co-authored-by: Orhun Parmaksız <[email protected]>
Suggestions applied (btw, I really like the refactor for the big switch case I had) and changes from main pulled :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution!
It was really fun working with you at the EuroRust workshop @dpecos! Wish to see you in the future events/open source projects. ❤️
Congrats on merging your first pull request! ⛰️ |
Description
This PR introduces the capability of grouping commits by attributes of the commit, i.e.
author.name
orauthor.email
.Motivation and Context
This changeset should cover the scenario described in #194.
The reporter of that issue wanted to create a new group based gathering the commits for a specific author name:
How Has This Been Tested?
In order to test it works, I've modified the
cliff.toml
file in this project to include a new group like this:which generates the following new group:
Screenshots / Logs (if applicable)
Types of Changes
Checklist: