Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): fix URLs in navigation bar #438

Merged
merged 1 commit into from
Jan 6, 2024
Merged

chore(website): fix URLs in navigation bar #438

merged 1 commit into from
Jan 6, 2024

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Jan 6, 2024

Description

Commit 1da7cac added Sponsor and GitHub links to the navigation bar. However, the links are not for this project.

This PR fixes these two links.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@welpo welpo requested a review from orhun as a code owner January 6, 2024 17:54
Copy link

welcome bot commented Jan 6, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edc6bc0) 41.67% compared to head (c2a334c) 41.67%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   41.67%   41.67%           
=======================================
  Files          15       15           
  Lines        1020     1020           
=======================================
  Hits          425      425           
  Misses        595      595           
Flag Coverage Δ
unit-tests 41.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks <3

@orhun orhun merged commit 70cab99 into orhun:main Jan 6, 2024
40 of 41 checks passed
Copy link

welcome bot commented Jan 6, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants