Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(args): add --no-exec flag for skipping command execution #458

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Jan 20, 2024

Description

Adds a new flag for skipping command execution:

git cliff --no-exec

Motivation and Context

closes #333

How Has This Been Tested?

Test fixtures

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (722efd6) 41.69% compared to head (d16d88e) 41.40%.

Files Patch % Lines
git-cliff/src/lib.rs 0.00% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
- Coverage   41.69%   41.40%   -0.28%     
==========================================
  Files          15       15              
  Lines        1022     1029       +7     
==========================================
  Hits          426      426              
- Misses        596      603       +7     
Flag Coverage Δ
unit-tests 41.40% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit 7ae77ff into main Jan 20, 2024
42 checks passed
@orhun orhun deleted the feat/no_exec_flag branch January 20, 2024 22:33
@orhun orhun mentioned this pull request Jan 20, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a CLI flag for disabling the command execution
2 participants