-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(npm): publish rc version for prereleases #528
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
=======================================
Coverage 41.14% 41.14%
=======================================
Files 15 15
Lines 1038 1038
=======================================
Hits 427 427
Misses 611 611
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hey @favna, I just created a RC version, but the NPM step failed: https://github.com/orhun/git-cliff/actions/runs/8412062961/job/23032878338 Was wondering if you have any about this 🤔 |
Woops, my bad. Created #574 that will fix that. |
Description
I wouldn't call myself a Bash legend but I think this does the trick. FWIW I tested it using a Bash session, but I can't say for 100% certain the
""
wrapping around the injected value from the GitHub workflow steps is correct, or if GitHub now adds double double quotes (as inif [ ""true"" = "true" ]
).As for the change on line 252, that's mostly just cleaned and moved to
package.json.tmpl
. Note that the binaries cannot be published withyarn npm publish
because that package.json doesn't reside in a yarn configured folder and we probably don't want that anyway.I looked at the history for
npm/git-cliff/package.json
and found this commit: 4218043#diff-09031284f88e0ed62cdbc8693d473bf5b8b9c5674257763d8d8ca0cebfc87a44. I see that you manually set the version to anrc
version and I assume this commit then triggered this workflow so that should make it all work.Motivation and Context
Requested in this comment: #514 (comment)
How Has This Been Tested?
I tested the individual steps using a Bash terminal session locally:
Screenshots / Logs (if applicable)
N.A.
Types of Changes
Checklist:
I have updated the documentation accordingly.N.A.I have formatted the code with rustfmt.N.A.I checked the lints with clippy.N.A.I have added tests to cover my changes.N.A.All new and existing tests passed.N.A.