-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(changelog): use root commit when --latest and there is only one tag #59
fix(changelog): use root commit when --latest and there is only one tag #59
Conversation
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 40.73% 40.44% -0.29%
==========================================
Files 13 13
Lines 825 831 +6
Branches 215 219 +4
==========================================
Hits 336 336
- Misses 380 386 +6
Partials 109 109
Continue to review full report at Codecov.
|
Hey, this sounds good. I'm keeping my eyes on this PR to add review when it's ready 👀 |
@orhun I'd like to let you know that I've created a setup action for Since you've released binaries, I was able to quickly build the action. Thank you for your work! I think it can be another option for https://github.com/orhun/git-cliff-action. |
Woo that's awesome! Thanks for doing that <3
For sure! Please add it to README.md when it is ready 👍🏼 Sometimes I think I should move all git-cliff related repos to the git-cliff organization. What do you think / are you open to that? |
@orhun Rebased and fixed some code, could you review this, please?
Thank you, I'll add it after releasing a stable tag!
Yes, I think it's a good idea because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, sorry for the late review. This overall looks good but I have a few points that I'd like you to change. GJ 👌🏼
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
Signed-off-by: Kenji Miyake <[email protected]>
@orhun Mm... Did you have any ideas about why the test is failed? |
However, I pushed some conventional commits (2ad4e51 & 4403240) and now it's fixed 🎉 |
Description
Changed to use the root commit when the
--latest
is used and there is only one commit.Since it uses the improved fixtures test added in #58, it depends on #58.
Motivation and Context
Generally in this case,
I think people expect the following result instead of raising an error.
How Has This Been Tested?
Please see
.github/fixtures/test-latest-with-one-tag/
.Screenshots / Output (if appropriate):
Please see
.github/fixtures/test-latest-with-one-tag/expected.md
.Types of changes
Checklist: