Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(template): add tests #674

Merged
merged 3 commits into from
Jun 5, 2024
Merged

test(template): add tests #674

merged 3 commits into from
Jun 5, 2024

Conversation

R11baka
Copy link
Contributor

@R11baka R11baka commented Jun 4, 2024

Description

Add some tests for template

@R11baka R11baka requested a review from orhun as a code owner June 4, 2024 20:04
@orhun
Copy link
Owner

orhun commented Jun 5, 2024

Hey, thanks for the PR! There seems to be a test failure:

 ---- template::test::render_template stdout ----
thread 'template::test::render_template' panicked at git-cliff-core/src/template.rs:233:9:
assertion `left == right` failed
  left: "\n\t\t## 1.0 - 2023\n\n\t\t### feat\n\t\t- Add xyz\n\n\t\t### fix\n\t\t- Fix abc\n\t\t"
 right: "\n\t\t## 1.0 - 2023\n\t\t\n\t\t### feat\n\t\t- Add xyz\n\t\t\n\t\t### fix\n\t\t- Fix abc\n\t\t"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@R11baka
Copy link
Contributor Author

R11baka commented Jun 5, 2024

Thanks.! Will see whats wrong

@orhun
Copy link
Owner

orhun commented Jun 5, 2024

Can you also run cargo fmt and commit the result? 😇

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.89%. Comparing base (e270235) to head (eb23a4c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   36.97%   36.89%   -0.07%     
==========================================
  Files          18       18              
  Lines        1350     1350              
==========================================
- Hits          499      498       -1     
- Misses        851      852       +1     
Flag Coverage Δ
unit-tests 36.89% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@R11baka
Copy link
Contributor Author

R11baka commented Jun 5, 2024

Yep. Seems fixed

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks a lot!

@orhun orhun changed the title chore(test) : increase tests coverage test(template): add tests Jun 5, 2024
@orhun orhun merged commit a51422d into orhun:main Jun 5, 2024
44 checks passed
@R11baka R11baka deleted the feature/addMoreTests branch July 5, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants